Skip to content

fix: prevent unnecessary flattening of headers during convertRes #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent unnecessary flattening of headers during convertRes #980

wants to merge 1 commit into from

Conversation

@cboar
Copy link

@cboar cboar commented Sep 10, 2025 •
edited
Loading

I ran into an issue where multiple Set-Cookie headers were being joined into a single header, which is not valid. I found that the convertRes function flattens all headers right before constructing the InternalResult. Since InternalResult allows string[] headers, I rewrote the parseHeaders to keep these as is. Since the method is also used elsewhere, I renamed the original implementation to flattenHeaders to better reflect its behavior.

Partially fixes #962

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e3faf1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cboar cboar force-pushed the fix/prevent-header-flatten branch from 07df95a to 2e3faf1 Compare September 11, 2025 03:12
@cboar
Copy link
Author

cboar commented Sep 11, 2025 •
edited
Loading

@sommeeeer I see #977 solves a similar issue exclusively for Location, but this also seems to affect Set-Cookie when multiple cookies are set.

For context, I am using a custom wrapper built for AWS ALB responses (not API Gateway), it has been helpful to not join the headers returned from InternalResult.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 15, 2025

Open in StackBlitz

pnpm add https://pkg.pr.new/@opennextjs/aws@980

commit: 2e3faf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Duplicated Location Headers is joined.

1 participant

@cboar